[cifmw_cephadm] rework container registry credentials #3576
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/576aa26d26aa4324940664287926d073 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 11s |
tosky
force-pushed
the
cephadm-default-container-registry
branch
from
7843b68 to
2c28ea5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cd7c78601ff7460f8a1832e9c4e5cd78 ❌ openstack-k8s-operators-content-provider FAILURE in 4m 35s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/98ebd1f977984043addd3e0b6c0f2379 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 57s |
tosky
force-pushed
the
cephadm-default-container-registry
branch
from
8426aab to
4a6566e
Compare
tosky
changed the title
tosky
force-pushed
the
cephadm-default-container-registry
branch
from
4a6566e to
147b782
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
As default, use the already known set of variables which are meant to be used to store the URL and the credentials of the container registry. Also, do not pass the credentials to the cephadm command line, but hide them inside a configuration file, so that the credentials are not exposed in the ansible logs. The configuration file is also removed when not needed anymore. The --registry-json argument has the same behavior of the combination of --registry-url/--registry-username/--registry-password which need to be passed at the same time anyway. Signed-off-by: Luigi Toscano <ltoscano@redhat.com>
tosky
force-pushed
the
cephadm-default-container-registry
branch
from
147b782 to
b286d89
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bd29518dcf5649e08c3c65f0037e4fc0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 37s |
|
recheck |
2 participants
As default, use the already known set of variables which are meant
to be used to store the URL and the credentials of the container
registry.
Also, do not pass the credentials to the cephadm command line,
but hide them inside a configuration file, so that the credentials
are not exposed in the ansible logs. The configuration file is also
removed when not needed anymore.
The --registry-json argument has the same behavior of the combination
of --registry-url/--registry-username/--registry-password which
need to be passed at the same time anyway.